[Buildbot] #2826: Failed FileUpload step generates a 0-sized file in the destination.

[Buildbot trac]

#2826: Failed FileUpload step generates a 0-sized file in the destination.
-------------------+-----------------------
Reporter:  juj     |      Owner:
    Type:  defect  |     Status:  new
Priority:  minor   |  Milestone:  undecided
 Version:  0.8.8   |   Keywords:
-------------------+-----------------------
 I have a build step like this:

 factory.addStep(FileUpload(slavesrc="file.png", workdir=dir_on_the_source,
 mode=0777, name="Upload",
 masterdest=WithProperties("~/web/dump/gfxapi_testresults/diff-%(buildnumber)s-"+builder+".png"),
 url=WithProperties("http://myserver.com/gfxapi_testresults/diff-%(buildnumber)s-"+builder+".png"),
 haltOnFailure=False, flunkOnFailure=False, hideStepIf=lambda results, s:
 results == FAILURE))

 Observed:
 If the source file 'file.png' does not exist on the build slave, the build
 master will still create a new file to the destination, but the size of
 that file will be zero.

 Also, if I remove the flunkOnFailure, haltOnFailure and hideStepIf
 directives, the log will not indicate a reason for the failure (e.g. "File
 upload failed, because source file was not found")

 Expected:

 No zero-sized files should be generated in the destination and a
 descriptive error message should be displayed in the output.

--
Ticket URL: <http://trac.buildbot.net/ticket/2826>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation