[Buildbot] #2834: Changes from perforce server not correctly listed in waterfall view since 0.8.9

[Buildbot trac]

#2834: Changes from perforce server not correctly listed in waterfall view since
0.8.9
------------------------+--------------------
Reporter:  lunochod     |       Owner:
    Type:  defect       |      Status:  new
Priority:  major        |   Milestone:  0.9.+
 Version:  0.8.9        |  Resolution:
Keywords:  p4, changes  |
------------------------+--------------------

Comment (by lunochod):

 Thank you very much for your help!

 You're right. There is this exception. I didn't see it until now because I
 only did a "reconfig" which apparently did not change the p4poller. I had
 to "stop/start" the server to set the server_tz. By the way (offtopic), is
 this behaviour a bug or a feature?

 After installing pytz, setting
 {{{server_tz=pytz.timezone('Europe/Berlin')}}} and check something into
 the perforce depot I see:
 {{{
          File ".../buildbot-0.8.9-py2.7.egg/buildbot/changes/p4poller.py",
 line 182, in _poll
             when = when.astimezone(dateutil.tz.tzlocal())
         exceptions.AttributeError: 'module' object has no attribute 'tz'
 }}}

 With my limited python knowledge and the help of the web I added {{{from
 dateutil import tz}}} to p4poller.py.

 Now, the code runs. But, sorry to say: The problem stays but has changed a
 little bit:
 For instance, a change with perforce describe -s 21831:
 {{{
 Change 28131 by foo at bar on 2014/07/16 16:58:52
 }}}
 gets the buildbot time stamp 1405526752 (Wed Jul 16 16:05:52 CEST 2014).

 Hmmm, almost an hour off. Do I have to specify a daylight-saving time
 component in the timezone?

 Anyway, I shouldn't have to use "server_tz" at all since the BuildBot
 manual states:
 {{{
 server_tz
     The timezone of the Perforce server, using the usual timezone format
 (e.g: Europe/Stockholm) in case it's in a different timezone than the
 buildbot master.
 }}}
 But the time zones of the perforce server and the buildbot server are the
 same.

--
Ticket URL: <http://trac.buildbot.net/ticket/2834#comment:7>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation