[Buildbot] #2834: Changes from perforce server not correctly listed in waterfall view since 0.8.9

[Buildbot trac]

#2834: Changes from perforce server not correctly listed in waterfall view since
0.8.9
------------------------+--------------------
Reporter:  lunochod     |       Owner:
    Type:  defect       |      Status:  new
Priority:  major        |   Milestone:  0.9.+
 Version:  0.8.9        |  Resolution:
Keywords:  p4, changes  |
------------------------+--------------------
Changes (by dustin):

 * keywords:  p4, changes, waterfall => p4, changes
 * type:  undecided => defect
 * milestone:  undecided => 0.9.+


Comment:

 Can you tell if this is a display error or an error in the P4Poller?  You
 can tell by looking in the 'changes' table in the db.  The column is UNIX
 timestamps, which are implicitly UTC.  If those are correct, then it's a
 display issue.  If those are off by 7200, then it's a P4Poller issue.

 The code to handle `server_tz` looks correct, if a little redundant (it
 converts from the server tz to the local tz with astimezone, then to UTC
 with datetime2epoch, when it could just go straight from server_tz to UTC
 with datetime2epoch).

 Some examples of the input to that code (m.group('when')) would be helpful
 to writing additional tests.

--
Ticket URL: <http://trac.buildbot.net/ticket/2834#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation