[Buildbot] #3081: buildbot.test.integration.test_try_client is flaky

[Buildbot trac]

#3081: buildbot.test.integration.test_try_client is flaky
-------------------+-----------------------
Reporter:  Ben     |       Owner:  dustin
    Type:  defect  |      Status:  assigned
Priority:  major   |   Milestone:  0.9.0
 Version:  master  |  Resolution:
Keywords:          |
-------------------+-----------------------

Comment (by dustin):

 {{{
 diff --git a/master/buildbot/pbmanager.py b/master/buildbot/pbmanager.py
 index d982115..fac5642 100644
 --- a/master/buildbot/pbmanager.py
 +++ b/master/buildbot/pbmanager.py
 @@ -116,24 +116,29 @@ class Dispatcher(service.AsyncService):
          self.portstr = portstr
          self.users = {}

          # there's lots of stuff to set up for a PB connection!
          self.portal = portal.Portal(self)
          self.portal.registerChecker(self)
          self.serverFactory = pb.PBServerFactory(self.portal)
          self.serverFactory.unsafeTracebacks = True
 -        self.port = strports.listen(portstr, self.serverFactory)
 +        self.port = None

      def __repr__(self):
          return "<pbmanager.Dispatcher for %s on %s>" % \
              (", ".join(self.users.keys()), self.portstr)

 +    def startService(self):
 +        assert not self.port
 +        self.port = strports.listen(self.portstr, self.serverFactory)
 +
      def stopService(self):
          # stop listening on the port when shut down
 +        assert self.port
          d = defer.maybeDeferred(self.port.stopListening)
          d.addCallback(lambda _: service.AsyncService.stopService(self))
          return d

      def register(self, username, password, pfactory):
          if debug:
              log.msg("registering username '%s' on pb port %s: %s"
                      % (username, self.portstr, pfactory))
 }}}

 trying that now..

--
Ticket URL: <http://trac.buildbot.net/ticket/3081#comment:19>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation