[Buildbot] #3081: buildbot.test.integration.test_try_client is flaky

[Buildbot trac]

#3081: buildbot.test.integration.test_try_client is flaky
-------------------+-----------------------
Reporter:  Ben     |       Owner:  dustin
    Type:  defect  |      Status:  assigned
Priority:  major   |   Milestone:  0.9.0
 Version:  master  |  Resolution:
Keywords:          |
-------------------+-----------------------

Comment (by dustin):

 {{{
 2014-12-26 17:59:44+0000 [-] <buildbot.changes.pb.PBChangeSource object at
 0x7f9c8473e110>._activityPoll: self.activate returned
 2014-12-26 17:59:44+0000 [-] <buildbot.changes.pb.PBChangeSource object at
 0x7f9c8473e110>._activityPollCall.start returned
 2014-12-26 17:59:44+0000 [-] <buildbot.changes.pb.PBChangeSource object at
 0x7f9c8473e110>.stopService deactivate_if_needed; active=True
 2014-12-26 17:59:44+0000 [-] <buildbot.changes.pb.PBChangeSource object at
 0x7f9c8473e110>.stopService deactivate_if_needed; set active=False
 2014-12-26 17:59:44+0000 [-] <buildbot.changes.pb.PBChangeSource object at
 0x7f9c8473e110>.stopService deactivate_if_needed; call self.deactivate
 2014-12-26 17:59:44+0000 [-] PBManager._unregister <pbmanager.Registration
 for change on tcp:0>
 2014-12-26 17:59:44+0000 [-] PBManager._unregister <pbmanager.Registration
 for None on tcp:0> - all users gone
 2014-12-26 17:59:44+0000 [-] disp.disownServiceParent returns None
 2014-12-26 17:59:44+0000 [-] <buildbot.schedulers.basic.AnyBranchScheduler
 object at 0x7f9c8473e210>.stopService deactivate_if_needed;
 self.deactivate done with True
 2014-12-26 17:59:44+0000 [-] <buildbot.schedulers.basic.AnyBranchScheduler
 object at 0x7f9c8473e210>.stopService return
 2014-12-26 17:59:44+0000 [-] <buildbot.changes.pb.PBChangeSource object at
 0x7f9c8473e110>.stopService deactivate_if_needed; self.deactivate done
 with True
 2014-12-26 17:59:44+0000 [-] <buildbot.changes.pb.PBChangeSource object at
 0x7f9c8473e110>.stopService return
 2014-12-26 17:59:44+0000 [-] BuildMaster is stopped
 2014-12-26 17:59:44+0000 [-] Main loop terminated.
 }}}

 with
 {{{
 diff --git a/master/buildbot/pbmanager.py b/master/buildbot/pbmanager.py
 index d982115..76d0ea1 100644
 --- a/master/buildbot/pbmanager.py
 +++ b/master/buildbot/pbmanager.py
 @@ -65,13 +65,20 @@ class PBManager(service.AsyncMultiService):
          return reg

      def _unregister(self, registration):
 +       log.msg("PBManager._unregister %s" % registration)
          disp = self.dispatchers[registration.portstr]
          disp.unregister(registration.username)
          registration.username = None
          if not disp.users:
 +           log.msg("PBManager._unregister %s - all users gone" %
 registration)
              disp = self.dispatchers[registration.portstr]
              del self.dispatchers[registration.portstr]
 -            return defer.maybeDeferred(disp.disownServiceParent)
 +            d = defer.maybeDeferred(disp.disownServiceParent)
 +            @d.addBoth
 +            def msg(x):
 +                log.msg("disp.disownServiceParent returns %s" % (x,))
 +                return x
 +            return d
          return defer.succeed(None)


 @@ -128,8 +135,13 @@ class Dispatcher(service.AsyncService):
              (", ".join(self.users.keys()), self.portstr)

      def stopService(self):
 +       log.msg("%s.stopService" % (self,))
          # stop listening on the port when shut down
          d = defer.maybeDeferred(self.port.stopListening)
 +        @d.addBoth
 +        def msg(x):
 +           log.msg("%s.stopService - stopListening returned %s" % (self,
 x))
 +           return x
          d.addCallback(lambda _: service.AsyncService.stopService(self))
          return d

 }}}

--
Ticket URL: <http://trac.buildbot.net/ticket/3081#comment:16>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation