[Buildbot] #3117: link to category broken in waterfall

Buildbot trac trac at buildbot.net
Thu Dec 18 12:04:38 UTC 2014


#3117: link to category broken in waterfall
----------------------+-----------------------
Reporter:  cyrilj     |      Owner:
    Type:  undecided  |     Status:  new
Priority:  major      |  Milestone:  undecided
 Version:  0.8.10     |   Keywords:
----------------------+-----------------------
 Hello,

 The links to a category in waterfall do not use the buildbotURL and are
 not relative.

 We access buildbot with a url like `http://localdomain/buildbot`
 and the category links are made by this code:
 {{{
 <a href="/waterfall?category={{ c }}">{{ c }}</a>  
 }}}
 so we end up at incorrect url `http://localdomain/waterfall?category={{ c
 }}` instead of `http://localdomain/buildbot/waterfall?category={{ c }}`

 A simple fix is to make the link relative.

 {{{
 --- a/buildbot/status/web/templates/waterfall.html      2014-12-13
 01:45:13.000000000 +0100
 +++ b/buildbot/status/web/templates/waterfall.html      2014-12-18
 12:02:05.230988821 +0100
 @@ -11,7 +11,7 @@
  {% if categories|length > 1 %}
   <p><b>Categories:</b>
   {% for c in categories %}
 -  <a href="/waterfall?category={{ c }}">{{ c }}</a>  
 +  <a href="?category={{ c }}">{{ c }}</a>  
   {% endfor -%}
   </p>
  {% endif %}
 }}}

--
Ticket URL: <http://trac.buildbot.net/ticket/3117>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation


More information about the bugs mailing list