[Buildbot] #2936: Buildbot - Traceback while polling for changes issue

[Buildbot trac]

#2936: Buildbot - Traceback while polling for changes issue
------------------------------------+------------------
Reporter:  solstice333              |       Owner:
    Type:  support-request          |      Status:  new
Priority:  major                    |   Milestone:
 Version:  0.8.9                    |  Resolution:
Keywords:  gitpoller, git, windows  |
------------------------------------+------------------
Changes (by zturner):

 * cc: zturner@… (added)


Comment:

 Hi, I'm encountering the same issue.  I believe the issue is this line:

             self.hProcess, self.hThread, self.pid, dwTid =
 win32process.CreateProcess(
                 cmd, cmdline, None, None, 1, 0, env, path, StartupInfo)

 in _dumbwin32proc.py

 In this case, "cmd" is "git".  There's a couple of important things to
 note about the first argument CreateProcess, from MSDN documentation
 (http://msdn.microsoft.com/en-
 us/library/windows/desktop/ms682425%28v=vs.85%29.aspx):

 ----
 The string can specify the full path and file name of the module to
 execute or it can specify a partial name. In the case of a partial name,
 the function uses the current drive and current directory to complete the
 specification. The function will not use the search path. This parameter
 must include the file name extension; no default extension is assumed.
 ----

 1) The function does not use the search path.
 2) The parameter must include the file name extension.

 Neither of these is true for this particular invocation of "git".  Indeed,
 just changing the argument to "git.exe" also doesn't fix the problem.
 Luckily this argument can be NULL, as described by reading further.

 ----
 The lpApplicationName parameter can be NULL. In that case, the module name
 must be the first white space–delimited token in the lpCommandLine string.
 ----

 So as long as lpCommandLine contains the full command line including the
 executable name, we can specify NULL for the first arument.  This is
 already the case in _dumbwin32proc.py.  In the above invocation, "cmdline"
 is equal to "git init c:\test_master\gitpoller-workdir"

 So, in summary, the fix is to simply change that line to pass None for the
 first argument.

--
Ticket URL: <http://trac.buildbot.net/ticket/2936#comment:17>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation