[Buildbot] #3112: Git step fails when source dir is missing

[Buildbot trac]

#3112: Git step fails when source dir is missing
---------------------+--------------------
Reporter:  dustin    |      Owner:  dustin
    Type:  defect    |     Status:  new
Priority:  critical  |  Milestone:  0.8.x
 Version:  0.8.10    |   Keywords:
---------------------+--------------------
 On the slave:
 {{{
 2014-12-14 17:23:09+0000 [Broker,client] startCommand:listdir [id 7]
 2014-12-14 17:23:09+0000 [Broker,client] ListDir /slave/build-cpp-
 ethereum-pr/source failed [Errno 2] No such file or directory: '/slave
 /build-cpp-ethereum-pr/source' 2014-12-14 17:23:09+0000 [Broker,client]
 SlaveBuilder.commandComplete <buildslave.commands.fs.ListDir instance at
 0x7f33d437cef0>
 }}}

 On the master:
 {{{
 Traceback (most recent call last):
   File "/usr/local/lib/python2.7/dist-packages/twisted/internet/defer.py",
 line 423, in errback
     self._startRunCallbacks(fail)
   File "/usr/local/lib/python2.7/dist-packages/twisted/internet/defer.py",
 line 490, in _startRunCallbacks
     self._runCallbacks()
   File "/usr/local/lib/python2.7/dist-packages/twisted/internet/defer.py",
 line 577, in _runCallbacks
     current.result = callback(current.result, *args, **kw)
   File "/usr/local/lib/python2.7/dist-packages/twisted/internet/defer.py",
 line 1155, in gotResult
     _inlineCallbacks(r, g, deferred)
 --- <exception caught here> ---
   File "/usr/local/lib/python2.7/dist-packages/twisted/internet/defer.py",
 line 1097, in _inlineCallbacks
     result = result.throwExceptionIntoGenerator(g)
   File "/usr/local/lib/python2.7/dist-packages/twisted/python/failure.py",
 line 389, in throwExceptionIntoGenerator
     return g.throw(self.type, self.value, self.tb)
   File "/home/buildbot/buildbot/master/buildbot/steps/source/git.py", line
 184, in full
     yield self.copy()
   File "/usr/local/lib/python2.7/dist-packages/twisted/internet/defer.py",
 line 1097, in _inlineCallbacks
     result = result.throwExceptionIntoGenerator(g)
   File "/usr/local/lib/python2.7/dist-packages/twisted/python/failure.py",
 line 389, in throwExceptionIntoGenerator
     return g.throw(self.type, self.value, self.tb)
   File "/home/buildbot/buildbot/master/buildbot/steps/source/git.py", line
 203, in incremental
     action = yield self._sourcedirIsUpdatable()
   File "/usr/local/lib/python2.7/dist-packages/twisted/internet/defer.py",
 line 577, in _runCallbacks
     current.result = callback(current.result, *args, **kw)
   File "/home/buildbot/buildbot/master/buildbot/steps/source/git.py", line
 580, in checkWithListdir
     files = cmd.updates['files'][0]
 exceptions.KeyError: 'files'
 }}}

 which isn't surprising - when the directory doesn't exist, listdir doesn't
 return files.

--
Ticket URL: <http://trac.buildbot.net/ticket/3112>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation