[Buildbot] #3103: error during master shutdown

[Buildbot trac]

#3103: error during master shutdown
-------------------+-------------------
Reporter:  sa2ajj  |      Owner:
    Type:  defect  |     Status:  new
Priority:  major   |  Milestone:  0.9.0
 Version:  master  |   Keywords:
-------------------+-------------------
 From `twistd.log`:

 {{{
 2014-12-08 19:02:14+0000 [-] Unhandled error in Deferred:
 2014-12-08 19:02:14+0000 [-] Unhandled Error
         Traceback (most recent call last):
           File "/usr/home/bbmaster/master/lib/python2.7/site-
 packages/twisted/internet/defer.py", line 423, in errback
             self._startRunCallbacks(fail)
           File "/usr/home/bbmaster/master/lib/python2.7/site-
 packages/twisted/internet/defer.py", line 490, in _startRunCallbacks
             self._runCallbacks()
           File "/usr/home/bbmaster/master/lib/python2.7/site-
 packages/twisted/internet/defer.py", line 577, in _runCallbacks
             current.result = callback(current.result, *args, **kw)
           File "/usr/home/bbmaster/master/lib/python2.7/site-
 packages/twisted/internet/defer.py", line 1155, in gotResult
             _inlineCallbacks(r, g, deferred)
         --- <exception caught here> ---
           File "/usr/home/bbmaster/master/lib/python2.7/site-
 packages/twisted/internet/defer.py", line 1097, in _inlineCallbacks
             result = result.throwExceptionIntoGenerator(g)
           File "/usr/home/bbmaster/master/lib/python2.7/site-
 packages/twisted/python/failure.py", line 389, in
 throwExceptionIntoGenerator
             return g.throw(self.type, self.value, self.tb)
           File "/usr/home/bbmaster/buildbot/master/buildbot/master.py",
 line 284, in stopService
             name=self.name, masterid=self.masterid)
           File "/usr/home/bbmaster/master/lib/python2.7/site-
 packages/twisted/internet/defer.py", line 1097, in _inlineCallbacks
             result = result.throwExceptionIntoGenerator(g)
           File "/usr/home/bbmaster/master/lib/python2.7/site-
 packages/twisted/python/failure.py", line 389, in
 throwExceptionIntoGenerator
             return g.throw(self.type, self.value, self.tb)
           File
 "/usr/home/bbmaster/buildbot/master/buildbot/data/masters.py", line 132,
 in masterStopped
             yield self._masterDeactivated(masterid, name)
           File "/usr/home/bbmaster/master/lib/python2.7/site-
 packages/twisted/internet/defer.py", line 1099, in _inlineCallbacks
             result = g.send(result)
           File
 "/usr/home/bbmaster/buildbot/master/buildbot/data/masters.py", line 164,
 in _masterDeactivated
             stepid=step['stepid'], results=RETRY)
           File "/usr/home/bbmaster/master/lib/python2.7/site-
 packages/twisted/internet/defer.py", line 1228, in unwindGenerator
             gen = f(*args, **kwargs)
         exceptions.TypeError: finishStep() takes exactly 4 arguments (3
 given)
 }}}

--
Ticket URL: <http://trac.buildbot.net/ticket/3103>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation