<div dir="ltr"><br><br><div class="gmail_quote"><div dir="ltr">On Thu, Oct 5, 2017 at 4:13 PM Neil Gilmore <<a href="mailto:ngilmore@grammatech.com">ngilmore@grammatech.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF">
Pierre,<br>
<br>
As always, thanks for the reply and advice.<br>
<br>
Note that I've clipped items that were addressed and that I have no
more comments on.</div><div text="#000000" bgcolor="#FFFFFF"><br>
<br>
<div class="m_2506705561842541629moz-cite-prefix">On 10/5/2017 3:45 AM, Pierre Tardy
wrote:<br>
</div>
</div><div text="#000000" bgcolor="#FFFFFF"><blockquote type="cite"><div dir="ltr"><div class="gmail_quote">
<div dir="ltr">On Wed, Oct 4, 2017 at 5:12 PM Neil Gilmore
<<a href="mailto:ngilmore@grammatech.com" target="_blank">ngilmore@grammatech.com</a>>
wrote:<br>
</div>
We have also been getting a lot of errors apparently tied to
build<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
collapsing, which we have turned on globally. If you've been
following<br>
along with the anecdotes, you'll know that we've also
slightly modified<br>
the circumstances under which a build will be collapsed to
ignore<br>
revision (in our case, we always want to use the latest --
we don't care<br>
about building anything 'intermediate'). We'd been getting a
lot of<br>
'tried to complete N buildequests, but only completed M'
warnings.</blockquote>
<div>We have seen also people seeing those issues. I have made
a fix in 0.9.10, but it looks like there are still people
complaining about it, but without much clue of what is wrong
beyond what was fixed.</div>
<div class="gmail_quote">The known problem was that the N
buildrequests were actually not uniques buildrequests, the
list contained duplicated.</div>
So those warnings should be pretty harmless beyond the noise.<br class="m_2506705561842541629inbox-inbox-Apple-interchange-newline">
</div></div></blockquote></div><div text="#000000" bgcolor="#FFFFFF"><blockquote type="cite"><div dir="ltr"><div class="gmail_quote"></div>
</div>
</blockquote>
<br>
Even though the transaction involving those buildrequests cancels
the transaction, so that the original work of marking requests
doesn't happen? Or would that just mean the requests don't get
skipped?<br></div></blockquote><div><br></div><div>No, there is no transaction canceled with this issue, this is only the upper layer freaking out because the db layer is returning less row updated than it is expecting.</div><div>The requests will get skipped as expected. This is just a spurious warning message.</div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div text="#000000" bgcolor="#FFFFFF"><br>
The builder we have to start workers does not use the custom steps,
though we have collapsing turned on globally. I have not seen that
builder having any skipped requests. It appears to be running
normally since yesterday.<br></div></blockquote><div>so everything back to normal?</div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div text="#000000" bgcolor="#FFFFFF"><br></div><div text="#000000" bgcolor="#FFFFFF">
I've used the manhole before, but not for this. I've had to use it
in the past to manually finish stuck builds, and to manually release
locks when necessary (though I haven't had to do that in a long
time).<br>
<br>
But we don't leave the manhole open, which means that I reconfig
when I'm going to use it (and since we use the same master.cfg for
all the masters, the manhole would try, and probably fail, to open
for all of them). Lately, that hasn't been a good option, because
when we were having the CPU spikes, the reconfig would never finish
(it might run for 24 hours or more until we were going to restart
the master anyway). It might work now, though, since we seem to have
solved the CPU problem.</div><div text="#000000" bgcolor="#FFFFFF"><br></div></blockquote><div>sounds good!</div><div><br></div><div><br></div></div></div>