<html><head></head><body>Ok, I'll add that change to my fork tomorrow and summit the pull request if it gets me working.<br>
<br>
Trevor<br><br><div class="gmail_quote">On 10 August 2017 16:59:11 BST, Pierre Tardy <tardyp@gmail.com> wrote:<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div dir="ltr">Indeed,<div>After looking at the source, it looks like we need to add one line in there:</div><div><a href="https://github.com/buildbot/buildbot/blob/master/master/buildbot/plugins/__init__.py#L40">https://github.com/buildbot/buildbot/blob/master/master/buildbot/plugins/__init__.py#L40</a><br /></div><div><table class="inbox-inbox-highlight inbox-inbox-tab-size inbox-inbox-js-file-line-container" style="box-sizing:border-box;border-collapse:collapse;color:rgb(36,41,46);font-family:-apple-system,system-ui,"Segoe UI",Helvetica,Arial,sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol";font-size:14px"><tbody style="box-sizing:border-box"><tr style="box-sizing:border-box"></tr><tr style="box-sizing:border-box"><td id="inbox-inbox-LC40" class="inbox-inbox-blob-code inbox-inbox-blob-code-inner inbox-inbox-js-file-line inbox-inbox-highlighted" style="box-sizing:border-box;padding:0px 10px;line-height:20px;vertical-align:top;overflow:visible;font-family:SFMono-Regular,Consolas,"Liberation Mono",Menlo,Courier,monospace;font-size:12px;word-wrap:normal;white-space:pre;background-color:rgb(255,251,221)">secrets <span class="inbox-inbox-pl-k" style="box-sizing:border-box;color:rgb(215,58,73)">=</span> get_plugins(<span class="inbox-inbox-pl-s" style="box-sizing:border-box;color:rgb(3,47,98)"><span class="inbox-inbox-pl-pds" style="box-sizing:border-box">'secrets</span><span class="inbox-inbox-pl-pds" style="box-sizing:border-box">'</span></span>, <span class="inbox-inbox-pl-c1" style="box-sizing:border-box;color:rgb(0,92,197)">None</span>)</td></tr><tr style="box-sizing:border-box"><td id="inbox-inbox-L41" class="inbox-inbox-blob-num inbox-inbox-js-line-number" style="box-sizing:border-box;padding:0px 10px;width:50px;min-width:50px;font-family:SFMono-Regular,Consolas,"Liberation Mono",Menlo,Courier,monospace;font-size:12px;line-height:20px;color:rgba(27,31,35,0.3);text-align:right;white-space:nowrap;vertical-align:top"><br /></td></tr></tbody></table>You can also import secrets from the actual location</div><div>from buildbot.secrets.providers.file import <span style="font-family:SFMono-Regular,Consolas,"Liberation Mono",Menlo,Courier,monospace;font-size:12px;white-space:pre">SecretInAFile</span></div><div><span style="color:rgb(111,66,193);font-family:SFMono-Regular,Consolas,"Liberation Mono",Menlo,Courier,monospace;font-size:12px;white-space:pre"><br /></span></div><div>Pierre<br /></div></div><br /><div class="gmail_quote"><div dir="ltr">On Thu, Aug 10, 2017 at 11:17 AM Trevor Hook <<a href="mailto:trevor.k.hook@googlemail.com">trevor.k.hook@googlemail.com</a>> wrote:<br /></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div>Sorry Pierre<br />
<br />
When I test that new string I get a new error.<br />
<br />
Error while parsing config file: name 'secrets' is not defined<br />
<br />
I've done a quick check to make sure package names are correct and the path to the secrets/providers seems correct<br />
<br />
I've also found where the name 'secrets' comes from in the secretsManager class and it is spelt the same way in <a href="http://setup.py" target="_blank">setup.py</a> and the manager class. <br />
<br />
I'm afraid I don't have time at the moment to start chasing this issue.<br />
<br />
I can submit a pull request to fix the sample code in the manual and developer documentation if you want but it seems wrong requesting a PR knowing the samples still don't work.</div><div><br />
<br />
Trevor<br /><br /></div><div><div class="gmail_quote">On 9 August 2017 18:34:36 BST, Pierre Tardy <<a href="mailto:tardyp@gmail.com" target="_blank">tardyp@gmail.com</a>> wrote:</div></div><div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div dir="ltr"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br />
c['secretsProviders'] = [util.SecretInAFile(dirname="my/path/way")]<br /></blockquote><div>its in secrets</div><div><a href="https://github.com/buildbot/buildbot/blob/master/master/setup.py#L257" target="_blank">https://github.com/buildbot/buildbot/blob/master/master/setup.py#L257</a></div><div><br /></div><div>c['secretsProviders'] = [secrets.SecretInAFile(dirname="my/path/way")] </div><div><br /></div><div>Thanks for the report. Can you submit a documentation PR?</div><div><br /></div><div>Regards,</div><div>Pierre</div></div></div>
</blockquote></div></div></blockquote></div>
</blockquote></div></body></html>