<!DOCTYPE html>
<html><head>
<meta charset="UTF-8">
</head><body><blockquote type="cite">Le 5 avril 2017 à 17:20, Pierre Tardy <tardyp@gmail.com> a écrit :<br><br><div dir="ltr">Hi Nicolas<br><br><div class="ox-28b4a05e22-gmail_quote"><div dir="ltr">On Wed, Apr 5, 2017 at 10:57 AM nicolas.lecureuil nicolas.lecureuil <<a href="mailto:nicolas.lecureuil@siveo.net">nicolas.lecureuil@siveo.net</a>> wrote:<br></div><blockquote><u class="ox-28b4a05e22-gmail_msg"></u><div class="ox-28b4a05e22-gmail_msg"><p class="ox-28b4a05e22-gmail_msg">Hi,<br class="ox-28b4a05e22-gmail_msg"></p><p class="ox-28b4a05e22-gmail_msg"><br class="ox-28b4a05e22-gmail_msg"></p><p class="ox-28b4a05e22-gmail_msg">i use Buildbot to build deb packages.<br class="ox-28b4a05e22-gmail_msg"></p><p class="ox-28b4a05e22-gmail_msg">i have a small question because i use :<br class="ox-28b4a05e22-gmail_msg"></p><p class="ox-28b4a05e22-gmail_msg"><br class="ox-28b4a05e22-gmail_msg"></p><p class="ox-28b4a05e22-gmail_msg">class UpstreamGetVersion(ShellCommand):<br class="ox-28b4a05e22-gmail_msg"> name ="upstreamgetversion"<br class="ox-28b4a05e22-gmail_msg"> command='grep version setup.py | grep = | cut -d = -f2 | cut -d"\'" -f2 '</p><p class="ox-28b4a05e22-gmail_msg">def evaluateCommand(self, cmd):<br class="ox-28b4a05e22-gmail_msg"> shell.SetPropertyFromCommand(command='grep version setup.py | grep = | cut -d = -f2 | cut -d"\'" -f2 ', property="upstreamPkgVer")<br class="ox-28b4a05e22-gmail_msg"> return ShellCommand.evaluateCommand(self, cmd)</p></div></blockquote><div>Your email agent mangled the whitespace, which does not make you code easy to read.</div><div><br></div><div>looks like you are not using shell.SetPropertyFromCommand in the way it is meant.</div><div>It is not a method you call in the evaluateCommand context, it is a step by itself</div><div>So you don't need any custom evaluateCommand step, you just need</div><div><br></div><div>f1.addStep(shell.SetPropertyFromCommand(command='grep version setup.py | grep = | cut -d = -f2 | cut -d"\'" -f2 ', property="upstreamPkgVer"))<br class="ox-28b4a05e22-gmail_msg"></div><div><br></div><div>Note that you can debug your properties setup in the properties tab of the UI.</div><div><br></div><div>Then, it is recommended to use new style steps for your customizations.</div><div>It is exactly the same except you redefine run(), and you do "return SUCCESS" instead of self.finished(SUCCESS).</div><div>Those new style steps are easier to use, and will avoid Buildbot to setup eight compatibility layer.</div><div>Last, you should know that self.getProperty() exists, and should simplify your code.</div><div>Instead of printing, you can also call self.addLog:</div><div><br></div><div>stdio_log = self.addLog("stdio")<br></div><div>stdio_log.addStdout(<span class="ox-28b4a05e22-inbox-inbox-Apple-converted-space" style="color: #212121; font-size: 13px;"> </span><span style="color: #212121; font-size: 13px;">'Debian package upstream version: {}'.format(self.debver))</span><br></div><div><span style="color: #212121; font-size: 13px;">You debug logs will be found in the buildbot UI instead of twisted.log</span></div></div></div></blockquote><p>Hi,<br></p><p><br></p><p>i have forgottent a big detail, i am using bb 0.8.9 ( as i need to port to bb 0.9.x in a second step but i want as a first step a working buildbot ( i am not that far from this :) )<br></p><p><br></p><p>so if i use:<br></p><p>f1.addStep(shell.SetPropertyFromCommand(command='grep version setup.py | grep = | cut -d = -f2 | cut -d"\'" -f2 ', property="upstreamPkgVer"))</p><p><br></p><p>for now i have :<br></p><p> self.addStep(UpstreamGetVersion(workdir=self._workdir))<br> self.addStep(DebComputeNewVersion(master_path=self._base_master_path, pkg_url=self._base_pkg_url))<br></p><p>if i use <br></p><p><br></p><p><br></p><p>f1.addStep(shell.SetPropertyFromCommand(command='grep version setup.py | grep = | cut -d = -f2 | cut -d"\'" -f2 ', property="upstreamPkgVer"))</p><p><br></p><p>i obtain : <br></p><p><br></p><p>LINE: pulse-agent-plugins (grep: setup.py: Aucun fichier ou dossier de ce type+git20170405233946.ea174fc-1) UNRELEASED; urgency=medium</p><p><br></p><p>which means something like "no file or folder"<br></p></body></html>