<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Hi Pierre,<br>
<br>
Thanks for the confirmation. Please note, because I failed to
mention it, that we set collapseRequests globally for most
schedulers.<br>
<br>
Our fix ended up being to append the master name to the schedulers.
We lose failover for the schedulers, though.<br>
<br>
I may look at your solution if I get some time. I may not understand
correctly, but it sounds like I'd end up with a builder with the
same name on 2 different masters. One would be the actual builder,
and the other would exist solely for its collapseRequests behavior?<br>
<br>
It would seem that an eventual fix would involve using the collapse
behavior attached specifically to a builder, if present. If not
present, the global config would be able to use the default
function, given function, or nothing. I don't think it would be too
hard to implement that. The only oddity right now is that scheduling
has to jump through the builder to find the function.<br>
<br>
Neil Gilmore<br>
grammatech.com<br>
<br>
<div class="moz-cite-prefix">On 11/23/2016 5:55 AM, Pierre Tardy
wrote:<br>
</div>
<blockquote
cite="mid:CAJ+soVf66oqAVLKb7Kh47R72fka0=Ofk7VEJQ2fjOBm4165vLw@mail.gmail.com"
type="cite">
<div dir="ltr">Hi Neil,
<div>Thanks for the info, this is indeed a design problem that
was unknown to me.</div>
<div>The collapse function will only work in case of a symmetric
multimaster setup.</div>
<div><br>
</div>
<div>in 0.8, the collapsing was done at the build start time,
this is why the config was done in the builder.</div>
<div>Now it is made at the buildrequest insertion time so that
the collapsing algorithm can be more efficient</div>
<div><br>
</div>
<div>You can workaround this by configuring dummy builderconfig
with only your collapse algorithm (and perhaps attach a dummy
slave that is meant to be always disconnected)</div>
<div><br>
</div>
<div>Pierre</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr">Le mar. 22 nov. 2016 à 23:20, Neil Gilmore <<a
moz-do-not-send="true" href="mailto:ngilmore@grammatech.com">ngilmore@grammatech.com</a>>
a écrit :<br>
</div>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">Hi everyone,<br
class="gmail_msg">
<br class="gmail_msg">
We might have a possible multi-master bug. Maybe it's already
known.<br class="gmail_msg">
<br class="gmail_msg">
It appears that if collapseRequests is active, buildrequests
will only<br class="gmail_msg">
collapse if the scheduler and builder are both on the same
master.<br class="gmail_msg">
Otherwise, it appears as though the collapse function will
never be<br class="gmail_msg">
found, and the build will not collapse.<br class="gmail_msg">
<br class="gmail_msg">
We're getting some requests queueing up that we didn't want.<br
class="gmail_msg">
<br class="gmail_msg">
Neil Gilmore<br class="gmail_msg">
<a moz-do-not-send="true" href="http://grammatech.com"
rel="noreferrer" class="gmail_msg" target="_blank">grammatech.com</a><br
class="gmail_msg">
_______________________________________________<br
class="gmail_msg">
users mailing list<br class="gmail_msg">
<a moz-do-not-send="true" href="mailto:users@buildbot.net"
class="gmail_msg" target="_blank">users@buildbot.net</a><br
class="gmail_msg">
<a moz-do-not-send="true"
href="https://lists.buildbot.net/mailman/listinfo/users"
rel="noreferrer" class="gmail_msg" target="_blank">https://lists.buildbot.net/mailman/listinfo/users</a><br
class="gmail_msg">
</blockquote>
</div>
</blockquote>
<br>
</body>
</html>