<div dir="ltr"><div>only one buildrequest seems to exist in the db, still Rest says 2 ;)<br></div><div><br></div><div>buildbot@3d9b217df954:~$ sqlite3 state.sqlite .dump |grep -i insert | grep buildrequest</div><div>INSERT INTO "buildrequests" VALUES(1,1,5,0,0,-1,1447950188,NULL,0);</div><div>INSERT INTO "buildrequest_claims" VALUES(1,1,1447950188);</div><div>buildbot@3d9b217df954:~$<br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Nov 19, 2015 at 4:55 PM, Francesco Di Mizio <span dir="ltr"><<a href="mailto:francescodimizio@gmail.com" target="_blank">francescodimizio@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>By itself it's not too bad as long as you know it. The moment you make a websocket connection and subscribe to events for that buildrequest id though, how can one assure he's receiving the right messages? What am I even subscribing to?<br></div><div><br></div>Do you want me to file a bug?<div><br></div><div><br></div></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Nov 18, 2015 at 5:46 PM, Francesco Di Mizio <span dir="ltr"><<a href="mailto:francescodimizio@gmail.com" target="_blank">francescodimizio@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">the default sqlite back end.</div><div><div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Nov 18, 2015 at 5:26 PM, Pierre Tardy <span dir="ltr"><<a href="mailto:tardyp@gmail.com" target="_blank">tardyp@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><p dir="ltr">Which db back end are you using? Normally there is unique key constraint on buildrequestid.</p><div><div>
<br><div class="gmail_quote"><div dir="ltr">Le mer. 18 nov. 2015 16:35, Francesco Di Mizio <<a href="mailto:francescodimizio@gmail.com" target="_blank">francescodimizio@gmail.com</a>> a écrit :<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Ps: managed to confirm that's only happening when passing in multiple sourcestamps.<div><br></div><div>Not sure if this is relevant but my master is set to never collapse anything.</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Nov 18, 2015 at 4:33 PM, Francesco Di Mizio <span dir="ltr"><<a href="mailto:francescodimizio@gmail.com" target="_blank">francescodimizio@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hey Pierre,<div><br></div><div>There you go:</div><div><br><div><span style="color:rgb(0,0,0);white-space:pre-wrap">{</span><br></div><div><pre style="color:rgb(0,0,0);word-wrap:break-word;white-space:pre-wrap"> "buildrequests": [
{
"builderid": 4,
"buildrequestid": 1,
"buildsetid": 1,
"claimed": true,
"claimed_at": 1447860725,
"claimed_by_masterid": 1,
"complete": true,
"complete_at": 1447860727,
"priority": 0,
"results": 2,
"submitted_at": 1447860725,
"waited_for": false
},
{
"builderid": 4,
"buildrequestid": 1,
"buildsetid": 1,
"claimed": true,
"claimed_at": 1447860725,
"claimed_by_masterid": 1,
"complete": true,
"complete_at": 1447860727,
"priority": 0,
"results": 2,
"submitted_at": 1447860725,
"waited_for": false
}
],
"meta": {
"total": 2
}
}</pre></div></div></div><div><div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Nov 18, 2015 at 1:55 PM, Pierre Tardy <span dir="ltr"><<a href="mailto:tardyp@gmail.com" target="_blank">tardyp@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi,<div><br></div><div>It looks indeed very weird that the rest api returns 2 times the exact same buildrequest<br><div>Normally (unless there is a bug), w<span style="line-height:1.5">e keep the track of the original buildrequest so that one entity wanting to know what's up with it can know which buildrequest know what's up with it even if there is collapsing.</span></div></div><div><br></div><div>I would like to see the return of rest api without field filtering:</div><div><br></div><div>api/v2/buildrequests?buildsetid=1<span style="line-height:1.5"><br></span></div></div><div><div><br><div class="gmail_quote"><div dir="ltr">Le mar. 17 nov. 2015 à 20:02, Francesco Di Mizio <<a href="mailto:francescodimizio@gmail.com" target="_blank">francescodimizio@gmail.com</a>> a écrit :<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>Came across a bit of an issue.</div><div><br></div><div>Is it possible that wehn calling addBuildsetForSourceStamps with 2 sourcestamps, buildbot will create 2 buildrequests and then only collapse them when one of the 2 kicks in? </div><div>Those 2 buildrequests in fact show up as 2 distinct ones in the web ui until the build starts. When it does one will remain.<br></div><div><br></div><div>However they still seem to exist after being collapsed</div><div><br></div><div>api/v2/buildrequests?buildsetid=1&field=buildrequestid&field=claimed_at&field=builderid&field=buildsetid<br></div><div><br></div><div>returns 2 identical buildrequests</div><div><br></div><div><pre style="color:rgb(0,0,0);word-wrap:break-word;white-space:pre-wrap"> "buildrequests": [
{
"builderid": 3,
"buildrequestid": 1,
"buildsetid": 1,
"claimed_at": 1447786507
},
{
"builderid": 3,
"buildrequestid": 1,
"buildsetid": 1,
"claimed_at": 1447786507
}</pre></div><div><br></div><div><br></div><div><br></div><div><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Nov 17, 2015 at 12:30 PM, Francesco Di Mizio <span dir="ltr"><<a href="mailto:francescodimizio@gmail.com" target="_blank">francescodimizio@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">it indeed worked very well. It was not clear to me that in the source step I was allowed to pass in the code base I want the step to deal with!<div><br></div><div>Much appreciated</div><span><font color="#888888"><div><br></div><div>Francesco</div></font></span></div><div><div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Nov 17, 2015 at 12:26 AM, Pierre Tardy <span dir="ltr"><<a href="mailto:tardyp@gmail.com" target="_blank">tardyp@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Yes, this is a very common use case that should fall upon the the codebase principle. You should really try and use codebase.</div><div><div><br><div class="gmail_quote"><div dir="ltr">Le lun. 16 nov. 2015 à 23:51, Francesco Di Mizio <<a href="mailto:francescodimizio@gmail.com" target="_blank">francescodimizio@gmail.com</a>> a écrit :<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">To clarify a bit more. The code coming from git is not part of the final product. The product infact does not depend at all on the code in Git. Git only contains code to help build what comes from p4. Also Github will never produce by itself a change to be built, those chances will only come from perforce.</div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Nov 16, 2015 at 11:29 PM, Francesco Di Mizio <span dir="ltr"><<a href="mailto:francescodimizio@gmail.com" target="_blank">francescodimizio@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>Hey Pierre,</div><div><br></div>in my case there's no change triggering the build. Or better all I have is a web app kicking a cutom scheduler in turn calling <span style="color:rgb(121,93,163);font-family:Consolas,'Liberation Mono',Menlo,Courier,monospace;font-size:12px;line-height:16.8px;white-space:pre-wrap">addBuildsetForSourceStamps</span><div><div><span style="color:rgb(121,93,163);font-family:Consolas,'Liberation Mono',Menlo,Courier,monospace;font-size:12px;line-height:16.8px;white-space:pre-wrap">Right now I am using a single Sourcestamp with an empty string named codebase to feed </span><span style="color:rgb(121,93,163);font-family:Consolas,'Liberation Mono',Menlo,Courier,monospace;font-size:12px;line-height:16.8px;white-space:pre-wrap">addBuildsetForSourceStamps</span></div><div>Should I just pass two SourceStamps in to <span style="color:rgb(121,93,163);font-family:Consolas,'Liberation Mono',Menlo,Courier,monospace;font-size:12px;line-height:16.8px;white-space:pre-wrap">addBuildsetForSourceStamps</span>?</div><div><br></div><div>I am not sure if that's what I need. Ideally if a build fails and I want to re-build the same thing, I'd like Git to always get latest. Hope it's a bit more clear now.</div><div><br></div><div>Thanks,</div><div> Francesco</div><div><br></div></div></div><div><div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Nov 16, 2015 at 9:08 PM, Pierre Tardy <span dir="ltr"><<a href="mailto:tardyp@gmail.com" target="_blank">tardyp@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi Francesco,<div><br></div><div>You need to specify two different codebases for your two git steps.</div><div>The source steps are overriding the branch arguments if there is a change triggering the build. changes are associated to codebase, and will only work for the corresponding source steps.</div><div><br></div><div>Regards</div><div><br></div></div><br><div class="gmail_quote"><div><div><div dir="ltr">Le lun. 16 nov. 2015 à 19:34, Francesco Di Mizio <<a href="mailto:francescodimizio@gmail.com" target="_blank">francescodimizio@gmail.com</a>> a écrit :<br></div></div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div><div dir="ltr">Hello guys,<div><br></div><div>my main checkout step is a p4 step. This is the repo that's got stuff I am interested into having compiling and tested.</div><div><br></div><div><br></div><div>My build scripts are coming from github. When I add a git step to check them out, Git step will no matter what use the branch property. Such a property (say 'main') only makes sense for the p4 step. I need to use an other property for the git step (like 'master') .</div><div><br></div><div>Docs say</div><div><br></div><div><div>@param branch: The branch or tag to check out by default. If</div><div>a build specifies a different branch, it will</div><div>be used instead of this.</div></div><div><br></div><div>So no matter what I pass to the step as branch, it'll still use the branch property. Any idea how to work this around? Basically I dont have to build a CI system around the git repo, ideally I'd just like to blindly check out its branches.</div><div><br></div><div>On a side note: is that way renderables beheave (just like 'branch' is a renderable for Git step)</div><div><br></div><div>Many thanks,</div><div> Frank</div></div></div></div>
_______________________________________________<br>
users mailing list<br>
<a href="mailto:users@buildbot.net" target="_blank">users@buildbot.net</a><br>
<a href="https://lists.buildbot.net/mailman/listinfo/users" rel="noreferrer" target="_blank">https://lists.buildbot.net/mailman/listinfo/users</a></blockquote></div>
</blockquote></div><br></div>
</div></div></blockquote></div><br></div>
</blockquote></div>
</div></div></blockquote></div><br></div>
</div></div></blockquote></div><br></div>
</blockquote></div>
</div></div></blockquote></div><br></div>
</div></div></blockquote></div><br></div>
</blockquote></div>
</div></div></blockquote></div><br></div>
</div></div></blockquote></div><br></div>
</div></div></blockquote></div><br></div>