<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Hi Pierre,<br>
<br>
<div class="moz-cite-prefix">On 1/4/2017 6:41 AM, Pierre Tardy
wrote:<br>
</div>
<blockquote
cite="mid:CAJ+soVfCgw13UyBVJzC+NDZf1B-_KCXQLvxOBKJrHFTD4Z+wHw@mail.gmail.com"
type="cite">
<div dir="ltr">
<div dir="ltr" class="gmail_msg">
<div class="gmail_quote gmail_msg">
<div dir="ltr" class="gmail_msg">Le mar. 3 janv. 2017
à 16:57, Neil Gilmore <<a moz-do-not-send="true"
href="mailto:ngilmore@grammatech.com" class="gmail_msg"
target="_blank">ngilmore@grammatech.com</a>> a
écrit :<br class="gmail_msg">
</div>
<blockquote class="gmail_quote gmail_msg" style="margin:0 0
0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000" class="gmail_msg">
Hi Pierre,<br class="gmail_msg">
<br class="gmail_msg">
Thanks for the reply.<br class="gmail_msg">
<br class="gmail_msg">
The current status of my code is that all the schedulers
now support checkConfig and reconfigService. I can also
(after some wrangling) start buildbot using any of the
schedulers. I have yet to test reconfiguration, and I
have not run any of the current buildbot unit tests. Nor
have I done any of the github stuff. I did subscribe to
the dev list (it was really just a matter of time).<br
class="gmail_msg">
</div>
</blockquote>
<div class="gmail_msg"><br class="gmail_msg">
</div>
</div>
</div>
<div dir="ltr" class="gmail_msg">
<div class="gmail_quote gmail_msg">
<div class="gmail_msg">I highly suggest to start with the
unit tests, as once it is understood help you to be much
more productive than typing buildbot reconfigure all the
time.</div>
<div class="gmail_msg"> Also, obviously creating an account
of github and pushing your code will help me to help you.</div>
</div>
</div>
<div dir="ltr" class="gmail_msg">
<div class="gmail_quote gmail_msg">
<div class="gmail_msg"><br class="gmail_msg">
</div>
</div>
</div>
</div>
</blockquote>
<br>
Well, I have the account. Now I have to learn how to use it. :)<br>
<br>
<div class="gmail_quote gmail_msg">
<blockquote class="gmail_quote gmail_msg" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000" class="gmail_msg">1.
Regularize compare_attrs for schedulers. In 0.9.2, several
schedulers appear to have a problem where they do not include
their base classes' compare_attrs. This wasn't as important
when there was no effective reconfiguration. <br
class="gmail_msg">
</div>
</blockquote>
</div>
<blockquote
cite="mid:CAJ+soVfCgw13UyBVJzC+NDZf1B-_KCXQLvxOBKJrHFTD4Z+wHw@mail.gmail.com"
type="cite">
<div dir="ltr">
<div dir="ltr" class="gmail_msg">
<div class="gmail_quote gmail_msg">
<div class="gmail_msg">There is indeed a need for cleanup,
but not the way you might think of it.</div>
<div class="gmail_msg">compare_attr uses <span style="background-color:rgb(248,238,199);color:rgb(51,51,51);font-family:consolas,"liberation mono",menlo,courier,monospace;font-size:12px;white-space:pre">reflect.accumulateClassList</span>,
which does take in account all compare_attr of all the
subclasses.</div>
<div class="gmail_msg"><a moz-do-not-send="true"
href="https://github.com/buildbot/buildbot/blob/master/master/buildbot/util/__init__.py#L136">https://github.com/buildbot/buildbot/blob/master/master/buildbot/util/__init__.py#L136</a><br>
</div>
<div class="gmail_msg">Some classes are explicitly adding
their parents compare_attr but this is either a mistake or
a legacy (I am not sure, this precedes my involvment in
this project)</div>
<div class="gmail_msg"><br>
</div>
</div>
</div>
</div>
</blockquote>
<br>
I hadn't seen that, being focussed elsewhere. I can certainly change
my code to remove the references to the parent in compare_attrs.<br>
<br>
<blockquote
cite="mid:CAJ+soVfCgw13UyBVJzC+NDZf1B-_KCXQLvxOBKJrHFTD4Z+wHw@mail.gmail.com"
type="cite">
<div dir="ltr">
<div dir="ltr" class="gmail_msg">
<div class="gmail_quote gmail_msg">
<blockquote class="gmail_quote gmail_msg" style="margin:0 0
0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000" class="gmail_msg"> <br
class="gmail_msg">
2. Add the checkConfig and reconfigService functions,
but leave them empty. This will at least ensure that I
have those setup up properly.<br class="gmail_msg">
</div>
</blockquote>
<div>+ remove the __init__. We should always use the
BuildbotService class __init__ for correct use of
checkConfig/reconfigService</div>
<blockquote class="gmail_quote gmail_msg" style="margin:0 0
0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000" class="gmail_msg"> <br
class="gmail_msg">
</div>
</blockquote>
</div>
</div>
</div>
</blockquote>
<br>
Yes, I should have been more precise. My current code leaves them
in, but all they do is print that they've been called, and with what
arguments. It made following through things easier. It's essentially
just stuff for my debugging.<br>
<br>
<blockquote
cite="mid:CAJ+soVfCgw13UyBVJzC+NDZf1B-_KCXQLvxOBKJrHFTD4Z+wHw@mail.gmail.com"
type="cite">
<div dir="ltr">
<div dir="ltr" class="gmail_msg">
<div class="gmail_quote gmail_msg">Some useful links for that:
<div><a moz-do-not-send="true"
href="http://docs.buildbot.net/latest/developer/tests.html">http://docs.buildbot.net/latest/developer/tests.html</a></div>
<div>The basic step to run the tests is the command:</div>
<div>trial buildbot</div>
<div><br>
</div>
</div>
</div>
</div>
</blockquote>
<br>
I did find that link, but it doesn't appear to mention how to run
them. Just knowing what the command line is helps immensely. There's
only one mention of trial on that page, and it's in an import
statement.<br>
<br>
Thanks!<br>
<br>
Neil Gilmore<br>
grammatech.com<br>
</body>
</html>