[Buildbot-commits] [Buildbot] #987: Missing command line for visual studio /clean

[Buildbot trac]

#987: Missing command line for visual studio /clean
-----------------------------+-------------------------
Reporter:  JDelfour          |       Owner:  dustin
    Type:  enhancement       |      Status:  closed
Priority:  patches-accepted  |   Milestone:  0.8.+
 Version:  0.8.1             |  Resolution:  worksforme
Keywords:  windows           |
-----------------------------+-------------------------
Changes (by dustin):

 * status:  accepted => closed
 * resolution:   => worksforme


Old description:

> Reference ticket: http://buildbot.net/trac/ticket/986
> I usually prefer doing a "clean" before a "build" without using the
> "rebuild" (which sometimes mess the dependencies...
>
> I guess you should add the following in the command lines of visual
> studio:
> if self.mode == "clean":
>     command.append("/Clean")

New description:

 Reference ticket: http://buildbot.net/trac/ticket/986
 I usually prefer doing a "clean" before a "build" without using the
 "rebuild" (which sometimes mess the dependencies...

 I guess you should add the following in the command lines of visual
 studio:
 if self.mode == "clean":
     command.append("/Clean")

--

Comment:

 With no updates, I'll close this.  I'm happy to see a pull request that
 accomplishes the requested change, or to hear from someone familiar with
 Windows that this is the right thing to do.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/987#comment:5>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation